Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

On Sun, 11 Nov 2007 15:15:10 +0100 Ingo Molnar <[email protected]> wrote:

> 
> * Erez Zadok <[email protected]> wrote:
> 
> > Small patch below fixes compile error.
> 
> > +			char name[sizeof(current->comm)];
> >  			warned++;
> >  			printk(KERN_INFO
> >  			       "warning: process `%s' sets w/ old libcap\n",
> > -			       get_task_comm(current));
> > +			       get_task_comm(name, current));
> 
> that's buggy - get_task_comm() returns void.
> 
> the proper fix would be to first do a get_task_comm() then pass in 
> 'name' as an argument to printk.

yup, it is all dependent upon http://lkml.org/lkml/2007/11/8/231
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)
    • From: Erez Zadok <[email protected]>
  • Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)
    • From: Ingo Molnar <[email protected]>

• Prev by Date: [patch] x86: fix taking DNA during 64bit sigreturn
• Next by Date: Kernel panic at boot with ondemand governor as default (2.6.24-rc2)
• Previous by thread: Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)
• Next by thread: patch conflicts (MMOTM "10-Nov-2007 22:46")
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]