Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

[David Howells <dhowells@redhat.com>]

Adrian Bunk <bunk@kernel.org> wrote:

> It's BTW not an improvement that you do not only rename them but change 
> such big functions to static inline functions in header files.

I'm not sure what you meant by that.

Renaming them indicates more clearly that their only purpose is for A.OUT
support.

Making them inline is an improvement because it compiles the code into the
binfmt_aout module rather than the core kernel, and gives the compiler
optimiser a chance to reduce the size of the overall code.

And the functions aren't actually all that big or complex.  They're about
shovelling data and don't do anything clever.

Actually, I could probably do another patch split to inline these functions
first before doing AOUT suppression.

> Something like this.

Was that an agreement with my suggested break up, or was there something more
meant to be there?

> But changes to binfmt_elf.c after the merge window that might introduce 
> regressions (e.g. you (ab)use CONFIG_BINFMT_AOUT where you might have to 
> introduce an CONFIG_ARCH_SUPPORTS_AOUT instead) decrease your chances of 
> being merged that late.

That was more or less what I wanted to do originally, but I was told to use
CONFIG_BINFMT_AOUT instead - which actually proves to have two variants:-(

Perhaps I could start with the patch that you mentioned to remove AOUT
interpreter support from binfmt_elf.  Can you point me at it or send it to me?
That's still not sufficient, but it removes part of the changes I have to
make.

> But you might be able to do something like a
>   cp include/asm-xtensa/a.out.h include/asm-mn10300/
> instead.

No.  That would be wrong.  MN10300 does not define an exec struct, and nor
should it provide an asm/a.out.h header.  It does not do AOUT format.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/