Re: [RFC 9/13] Char: nozomi, lock cleanup

On Samstag 10 November 2007 00:48:52, you (Jiri Slaby) wrote:
> nozomi, lock cleanup
> 
> - semaphore is deprecated, use mutex instead
> - don't return -ERESTARTSYS when signal might not be pending since it's not
>   permitted (unknown retval mioght reach userspace)
> - don't lock interruptible in close or the card might not be stopped on last
>   close

Good catches. But i had to change it a bit, especially the mutex_trylock.
>From mutex.c: "..it is negated to the down_trylock() return values!
Be careful about this when converting semaphores to mutexes." ;-)
Now it works again (doesn't deadlock my card anymore).

Thanks,
Frank
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC 9/13] Char: nozomi, lock cleanup
    • From: Jiri Slaby <[email protected]>

• Prev by Date: Re: [RFC 8/13] Char: nozomi, tty cleanup
• Next by Date: Re: [RFC! 10/13] Char: nozomi, fix tty_flip_buffer_push
• Previous by thread: [RFC 9/13] Char: nozomi, lock cleanup
• Next by thread: [RFC! 10/13] Char: nozomi, fix tty_flip_buffer_push
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]