Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

Hi Christoph,

On Tue, Nov 06, 2007 at 05:11:34PM -0800, Christoph Lameter wrote:
> @@ -613,11 +606,7 @@ static void shrink_dcache_for_umount_sub
>  			spin_lock(&dcache_lock);
>  			list_for_each_entry(loop, &dentry->d_subdirs,
>  					    d_u.d_child) {
> -				if (!list_empty(&loop->d_lru)) {
> -					dentry_stat.nr_unused--;
> -					list_del_init(&loop->d_lru);
> -				}
> -
> +				dentry_lru_remove(dentry);

Shouldn't this be dentry_lru_remove(loop)?

	Hannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 04/23] dentries: Extract common code to remove dentry from lru
    • From: Christoph Lameter <[email protected]>
  • Re: [patch 04/23] dentries: Extract common code to remove dentry from lru
    • From: Jörn Engel <[email protected]>

• References:
  • [patch 00/23] Slab defragmentation V6
    • From: Christoph Lameter <[email protected]>
  • [patch 04/23] dentries: Extract common code to remove dentry from lru
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [patch 1/4] x86: FIFO ticket spinlocks
• Next by Date: Re: [patch 07/23] SLUB: Add defrag_ratio field and sysfs support.
• Previous by thread: [patch 04/23] dentries: Extract common code to remove dentry from lru
• Next by thread: Re: [patch 04/23] dentries: Extract common code to remove dentry from lru
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]