Re: [GIT PATCH] PCI patches for 2.6.24-rc1

[Linus Torvalds <torvalds@linux-foundation.org>]

On Tue, 6 Nov 2007, Theodore Tso wrote:
> 
> hmm, I wonder if it would be a good idea to put together a git hook
> script that looks for things that look like git commit ID's, and if
> they aren't valid commit ID's that appear in the repository, the
> maintainer gets a warning when they do a "git am" or otherwise suck in
> a patch that was sent via e-mail...

Well, the thing is, sometimes it makes sense.

In the stable tree, for example, the commits often point to the particular 
commit in the *development* tree that the particular stable commit was 
cherry-picked from. And that all makes perfect sense - but such a commit 
will not even exist in that tree (very much by definition: the whole point 
of a stable tree is to *not* have all the development commits in that 
tree, so just individual commits get moved over).

So it does make sense to point to commits in totally independent trees at 
times.

Yes, it could be an option, and yes, you could probably enable/disable it 
on a per-repository basis (ie the above kind of thing tens to make sense 
for certain repositories but not others). But it's definitely not 
something that necessarily always makes sense to do, so it's likely not a 
good default (and if it's not a default, then mistakes will continue to 
happen).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/