Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig

[Adrian Bunk <bunk@kernel.org>]

On Tue, Nov 06, 2007 at 09:13:39AM +0100, Sam Ravnborg wrote:
> >  > +	depends on X86_32 && X86_ELAN
> >  >  	---help---
> >  >  	  This adds the CPUFreq driver for AMD Elan SC520 processor.
> > 
> > X86_ELAN should depend on X86_32 rather than adding this everywhere.
> 
> ...
> 
> >  >  	bool
> >  >  	depends on X86_POWERNOW_K7 && ACPI_PROCESSOR
> >  >  	depends on !(X86_POWERNOW_K7 = y && ACPI_PROCESSOR = m)
> >  > +	depends on X86_32
> >  >  	default y
> > 
> > This 2nd hunk shouldn't be necessary, as it depends on X86_POWERNOW_K7
> > which you just added the 32bit dependancy to. 
> > 
> >  >  config X86_SPEEDSTEP_RELAXED_CAP_CHECK
> >  >  	bool "Relaxed speedstep capability checks"
> >  > -	depends on (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
> >  > +	depends on X86_32 && (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
> > 
> > Should also be unnecessary due to those items now being 32bit dependant.
> 
> In several cases the "depends on X86_32 were added not as a necessity
> but just to make it obvious that a given symbol is 32 bit specific.
> I can drop doing it this way if it is anyway obvious from the context.
> 
> Will try to do so in next patch-set, due tonigt if things goes OK.

Please keep them for now (and also add them for the other cases like 
RWSEM_XCHGADD_ALGORITHM).

My impression of the whole x86 merge is that a quite mechanical approach 
is the best one for avoiding to introduce bugs, and cleaning such 
harmless stuff later is not a problem.

> 	Sam

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/