Re: [PATCH] CRIS v10 serial driver rewrite take two

[Jesper Nilsson <jesper.nilsson@axis.com>]

On Mon, Nov 05, 2007 at 02:45:31PM +0100, Jiri Slaby wrote:
> On 11/05/2007 02:11 PM, Jesper Nilsson wrote:
> >  	if (tty_hung_up_p(filp) ||
> >  	    (info->flags & ASYNC_CLOSING)) {
> >  		if (info->flags & ASYNC_CLOSING)
> 
> You can remove this (__^) line now, the test itself is inside
> wait_event_interruptible macro yet.

Ah, yes, so it is.

> > -			interruptible_sleep_on(&info->close_wait);
> > +			wait_event_interruptible(info->close_wait,
> > +				!info->flags & ASYNC_CLOSING);
> 
> This is still buggy, I intentionally put the parenthesis around "info->flags &
> ASYNC_CLOSING" in my previous mail. This way it will ever evaluate to 0 (since
> it is as same as (!info->flags) & ASYNC_CLOSING now).

Of course. I thought about it, but obviously my brain used teflon-coated
memory to store that information. I'll be back with yet another version.

> Jiri Slaby (jirislaby@gmail.com)

Thanks again for you comments,

/^JN - Jesper Nilsson
--
               Jesper Nilsson -- jesper.nilsson@axis.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/