On Mon, 5 Nov 2007, Geert Uytterhoeven wrote:
> On Mon, 5 Nov 2007, Li Zefan wrote:
> > The size passing to memset is wrong.
> >
> > Signed-off-by Li Zefan <[email protected]>
>
> Acked-by: Geert Uytterhoeven <[email protected]>
As this leaks 24 bytes of uninitialized stack to user space, probably this
should be applied to -stable, too?
> > ---
> > drivers/video/ps3fb.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> > index b3463dd..75836aa 100644
> > --- a/drivers/video/ps3fb.c
> > +++ b/drivers/video/ps3fb.c
> > @@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info)
> >
> > static int ps3fb_get_vblank(struct fb_vblank *vblank)
> > {
> > - memset(vblank, 0, sizeof(&vblank));
> > + memset(vblank, 0, sizeof(*vblank));
> > vblank->flags = FB_VBLANK_HAVE_VSYNC;
> > return 0;
> > }
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/
Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
