Re: duplicated include files

[Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>]

On Sun, 4 Nov 2007, Marco Costalba wrote:
> make includecheck does not work for me. Linux tree is from latest git.
> 
> bash-3.2$ pwd
> /git/linux-2.6
> 
> bash-3.2$ make includecheck
> find * \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o
> -name .pc -o -name .hg -o -name .git \) -prune -o \
>                 -name '*.[hcS]' -type f -print | sort \
>                 | xargs perl -w scripts/checkincludes.pl
> Can't open perl script "scripts/checkincludes.pl": No such file or directory
> make[1]: *** [includecheck] Error 123
> make: *** [sub-make] Error 2
> 
> bash-3.2$ ls scripts/checkincludes.pl
> scripts/checkincludes.pl

Are you building in a different tree than the source tree? The patch below
fixed it for me.

Question: Why don't GENKSYMS and KALLSYMS need the $(srctree) prefix?
---
Subject: kbuild: Add missing srctree prefix for includecheck and versioncheck

Add missing $(srctree)/ prefix for scripts used by the includecheck and
versioncheck make targets

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- a/Makefile
+++ b/Makefile
@@ -1414,12 +1414,12 @@ tags: FORCE
 includecheck:
 	find * $(RCS_FIND_IGNORE) \
 		-name '*.[hcS]' -type f -print | sort \
-		| xargs $(PERL) -w scripts/checkincludes.pl
+		| xargs $(PERL) -w $(srctree)/scripts/checkincludes.pl
 
 versioncheck:
 	find * $(RCS_FIND_IGNORE) \
 		-name '*.[hcS]' -type f -print | sort \
-		| xargs $(PERL) -w scripts/checkversion.pl
+		| xargs $(PERL) -w $(srctree)/scripts/checkversion.pl
 
 namespacecheck:
 	$(PERL) $(srctree)/scripts/namespace.pl

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619