On Mon, 2007-11-05 at 10:21 +0800, Li Zefan wrote:
> The size passing to memset is wrong.
>
> Signed-off-by Li Zefan <[email protected]>
Good catch, looks like a remain of when path was an array on the stack.
Thanks !
Acked-by: Benjamin Herrenschmidt <[email protected]>
>
> ---
> arch/powerpc/kernel/prom_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 1db10f7..1add6ef 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1244,7 +1244,7 @@ static void __init prom_initialize_tce_table(void)
> local_alloc_bottom = base;
>
> /* It seems OF doesn't null-terminate the path :-( */
> - memset(path, 0, sizeof(path));
> + memset(path, 0, PROM_SCRATCH_SIZE);
> /* Call OF to setup the TCE hardware */
> if (call_prom("package-to-path", 3, 1, node,
> path, PROM_SCRATCH_SIZE-1) == PROM_ERROR) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
