Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

[Casey Schaufler <casey@schaufler-ca.com>]

--- "Ahmed S. Darwish" <darwish.07@gmail.com> wrote:

> On 11/4/07, Pavel Machek <pavel@ucw.cz> wrote:
> > Hi!
> >
> > > > Still to come:
> > > >
> > > >   - Final cleanup of smack_load_write and smack_cipso_write.
> > >
> > > Hi All,
> > >
> > > After agreeing with Casey on the "load" input grammar yesterday, here's
> > > the final grammar and its parser (which needs more testing):
> > >
> > > A Smack Rule in an "egrep" format is:
> > >
> > > "^[:space:]*Subject[:space:]+Object[:space:]+[rwxaRWXA-]+[:space:]*\n"
> > >
> > > where Subject/Object strings are in the form:
> > >
> > > "^[^/[:space:][:cntrl:]]{1,SMK_MAXLEN}$"
> >
> > Can we avoid string parsers in the kernel?

Woof. We've devolved into Al saying it must be done this way,
and Pavel saying it can't be done this way.

That's OK. Maybe it's time that I stepped back and came up
with a twisted mechanism for achieving my ends, as the obvious
mechanism appears as if it will always call down disapproval.
 
> I've suggested that at first, but (hoping not to misquote Al) Al viro
> said that the parsing is simple enough and no need exists for a
> user-space utility.
> 
> >
> > > +static inline int isblank(char c)
> > > +{
> > > +     return (c == ' ' || c == '\t');
> > > +}
> >
> > This sounds like enough for 'NAK'.
> >
> 
> Would you please show the reason for the NAK so I can modify the code ?

yeah, my head needs scratching after that one.

> 
> Thank you,
> 
> >                                                 Pavel,
> >                 who still thinks smack rules should be parsed
> >                 in userspace and compiled into selinux rules...

Casey, who still thinks Pavel doesn't get it.


Casey Schaufler
casey@schaufler-ca.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/