Date: Sun, 4 Nov 2007 09:44:56 +0100 From: Jens Axboe <[email protected]> Torsten Kaiser wrote: > Looking that calltrace upwards, it seems replacing the > memset(dma->sglist,...) with sg_init_table(...) would fix the BUG_ON() > as that inits the SG_MAGIC. Tested-by: Torsten Kaiser <[email protected]> Signed-off-by: Stefan Richter <[email protected]> --- drivers/ieee1394/dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.24-rc1/drivers/ieee1394/dma.c =================================================================== --- linux-2.6.24-rc1.orig/drivers/ieee1394/dma.c +++ linux-2.6.24-rc1/drivers/ieee1394/dma.c @@ -103,8 +103,7 @@ int dma_region_alloc(struct dma_region * goto err; } - /* just to be safe - this will become unnecessary once sglist->address goes away */ - memset(dma->sglist, 0, dma->n_pages * sizeof(*dma->sglist)); + sg_init_table(dma->sglist, dma->n_pages); /* fill scatter/gather list with pages */ for (i = 0; i < dma->n_pages; i++) { -- Stefan Richter -=====-=-=== =-== --=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: s/g list fix
- From: Stefan Richter <[email protected]>
- [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: s/g list fix
- References:
- 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: "Torsten Kaiser" <[email protected]>
- Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: Stefan Richter <[email protected]>
- Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: "Torsten Kaiser" <[email protected]>
- Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: Stefan Richter <[email protected]>
- Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: Jens Axboe <[email protected]>
- Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: Jens Axboe <[email protected]>
- Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- From: "Torsten Kaiser" <[email protected]>
- 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- Prev by Date: 2.6.23.1: mdadm/raid5 hung/d-state
- Next by Date: [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: s/g list fix
- Previous by thread: Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
- Next by thread: [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: s/g list fix
- Index(es):
 |