[PATCH] arch/ppc: Remove an unnecessary pci_dev_put.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Julia Lawall <[email protected]>

Remove an unnecessary pci_dev_put.  pci_dev_put is called implicitly by the
subsequent call to pci_get_device.

The problem was detected using the following semantic patch, and corrected
by hand.

@@
expression dev;
expression E;
@@

- pci_dev_put(dev)
  ... when != dev = E
- pci_get_device(...,dev)


Signed-off-by: Julia Lawall <[email protected]>

---

diff -up a/arch/ppc/platforms/prep_pci.c b/arch/ppc/platforms/prep_pci.c
--- a/arch/ppc/platforms/prep_pci.c	2007-11-03 15:25:45.000000000 +0100
+++ b/arch/ppc/platforms/prep_pci.c	2007-11-03 15:25:59.000000000 +0100
@@ -1099,7 +1099,6 @@ prep_pib_init(void)
 				pci_write_config_byte(dev, 0x43, reg);
 			}
 		}
-		pci_dev_put(dev);
 	}

 	if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux