Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules

On 11/1/07, Jan Engelhardt <[email protected]> wrote:
>
> On Nov 1 2007 17:54, Ahmed S. Darwish wrote:
> >+
> >+static inline int isblank(char c)
> >+{
> >+      return (c == ' ' || c == '\t');
> >+}
>
> Use isspace().
>

isspace accepts newlines and carriage-returns too which is not
accepted between elements of a one rule.

> >+      for (i = 0; i < count && data[i]; i ++)
> >...
> >+                      subjectstr[(*label_len) ++] = data[i];
>
> i++ w/o space
>

Notes Taken. Thanks for the review.

Regards,

Darwish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Smackv9: Use a stateful parser for parsing Smack rules
    • From: "Ahmed S. Darwish" <[email protected]>
  • Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: question about sata-error on boot.
• Next by Date: [PATCH 0/3] eCryptfs: extent offset fix, crypto performance, and larger header regions
• Previous by thread: Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules
• Next by thread: [PATCH 1/2] [NetLabel] Introduce a new kernel configuration API for NetLabel - Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]