Re: [PATCH] Fix delay accounting regression

* Balbir Singh <[email protected]> wrote:

> Fix the delay accounting regression introduced by commit 
> 75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info 
> data associated with it. task_struct sched_info structure is used by 
> delay accounting to provide back statistics to user space.

no, this really is broken code. sched_clock() is not a generally 
reliable time source so at a minimum the rq->clock fix i mentioned is 
needed. What user-space tools are utilizing delay-accounting by the way? 
We have most of this data available under SCHEDSTATS - how about 
consolidating CONFIG_TASK_DELAY_ACCT into CONFIG_SCHEDSTATS?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Fix delay accounting regression
  - From: Balbir Singh <[email protected]>
- Re: [PATCH] Fix delay accounting regression
  - From: Balbir Singh <[email protected]>
- Re: [PATCH] Fix delay accounting regression
  - From: "Guillaume Chazarain" <[email protected]>

References:
- [PATCH] Fix delay accounting regression
  - From: Balbir Singh <[email protected]>

Prev by Date: Re: 2.6.24-rc1: OOPS at acpi_battery_update
Next by Date: [PATCH 3/3] tty - fix tty network driver interactions with TCGET/TCSET calls
Previous by thread: [PATCH] Fix delay accounting regression
Next by thread: Re: [PATCH] Fix delay accounting regression
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]