Re: [PATCH 1/16] CRIS architecture: Correct compile errors

[Jesper Nilsson <jesper.nilsson@axis.com>]

On Tue, Oct 30, 2007 at 03:14:00PM -0700, Andrew Morton wrote:
> On Tue, 30 Oct 2007 10:28:11 +0100
> Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> 
> > Remove include of asm/bitops.h, not needed here, corrects compilation error
> > (__le64 undefined).
> [snip]
>
> This doesn't apply and I'm not sure that it is still needed or correct.
> 
> I'll drop it.

Unfortunately it is still needed, I'll resend a fresh patch
against Linus git tree.

Compile error:

  CC      arch/cris/kernel/asm-offsets.s
In file included from include/asm/byteorder.h:23,
                 from include/asm-generic/bitops/le.h:5,
                 from include/asm-generic/bitops/ext2-non-atomic.h:4,
                 from include/asm/bitops.h:163,
                 from include/linux/bitops.h:17,
                 from include/asm/posix_types.h:55,
                 from include/linux/posix_types.h:47,
                 from include/linux/types.h:11,
                 from include/linux/capability.h:16,
                 from include/linux/sched.h:49,
                 from arch/cris/kernel/asm-offsets.c:1:
include/linux/byteorder/little_endian.h:43: parse error before "__cpu_to_le64p"
include/linux/byteorder/little_endian.h:44: warning: return type defaults to `int'
include/linux/byteorder/little_endian.h: In function `__cpu_to_le64p':
include/linux/byteorder/little_endian.h:45: `__le64' undeclared (first use in this function)
....

> Please always prepare and test patches against the latest kernel.  2.6.23
> is very much _not_ the latest kernel - there is a 50MB diff between 2.6.23
> and 2.6.24-rc1.  That's a lot of difference.

I will do so from now on.

/^JN - Jesper Nilsson
--
               Jesper Nilsson -- jesper.nilsson@axis.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/