Linus:
On the per-architecture side, I do think it would be better to *not* have
internal architecture knowledge in a generic file, and as such a line like
depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32
really shouldn't exist in a file like kernel/Kconfig.instrumentation.
It would be much better to do
depends on ARCH_SUPPORTS_KPROBES
in that generic file, and then architectures that do support it would just
have a
bool ARCH_SUPPORTS_KPROBES
default y
in *their* architecture files. That would seem to be much more logical,
and is readable both for arch maintainers *and* for people who have no
clue - and don't care - about which architecture is supposed to support
which interface...
Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Linus Torvalds <[email protected]>
CC: Sam Ravnborg <[email protected]>
---
arch/avr32/Kconfig | 4 ++++
arch/ia64/Kconfig | 4 ++++
arch/powerpc/Kconfig | 4 ++++
arch/ppc/Kconfig | 4 ++++
arch/s390/Kconfig | 4 ++++
arch/sparc64/Kconfig | 4 ++++
arch/x86/Kconfig.i386 | 4 ++++
arch/x86/Kconfig.x86_64 | 4 ++++
kernel/Kconfig.instrumentation | 2 +-
9 files changed, 33 insertions(+), 1 deletion(-)
Index: linux-2.6-lttng.stable/arch/avr32/Kconfig
===================================================================
--- linux-2.6-lttng.stable.orig/arch/avr32/Kconfig 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/avr32/Kconfig 2007-10-30 20:19:08.000000000 -0400
@@ -70,6 +70,10 @@ config GENERIC_BUG
default y
depends on BUG
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
source "init/Kconfig"
menu "System Type and features"
Index: linux-2.6-lttng.stable/arch/ia64/Kconfig
===================================================================
--- linux-2.6-lttng.stable.orig/arch/ia64/Kconfig 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/ia64/Kconfig 2007-10-30 20:19:08.000000000 -0400
@@ -103,6 +103,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
choice
prompt "System type"
default IA64_GENERIC
Index: linux-2.6-lttng.stable/arch/powerpc/Kconfig
===================================================================
--- linux-2.6-lttng.stable.orig/arch/powerpc/Kconfig 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/powerpc/Kconfig 2007-10-30 20:19:08.000000000 -0400
@@ -167,6 +167,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
source "init/Kconfig"
source "arch/powerpc/platforms/Kconfig"
Index: linux-2.6-lttng.stable/arch/ppc/Kconfig
===================================================================
--- linux-2.6-lttng.stable.orig/arch/ppc/Kconfig 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/ppc/Kconfig 2007-10-30 20:19:08.000000000 -0400
@@ -73,6 +73,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
source "init/Kconfig"
menu "Processor"
Index: linux-2.6-lttng.stable/arch/s390/Kconfig
===================================================================
--- linux-2.6-lttng.stable.orig/arch/s390/Kconfig 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/s390/Kconfig 2007-10-30 20:19:08.000000000 -0400
@@ -56,6 +56,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
source "init/Kconfig"
menu "Base setup"
Index: linux-2.6-lttng.stable/arch/sparc64/Kconfig
===================================================================
--- linux-2.6-lttng.stable.orig/arch/sparc64/Kconfig 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/sparc64/Kconfig 2007-10-30 20:19:08.000000000 -0400
@@ -80,6 +80,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
choice
prompt "Kernel page size"
default SPARC64_PAGE_SIZE_8KB
Index: linux-2.6-lttng.stable/arch/x86/Kconfig.i386
===================================================================
--- linux-2.6-lttng.stable.orig/arch/x86/Kconfig.i386 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/x86/Kconfig.i386 2007-10-30 20:19:08.000000000 -0400
@@ -95,6 +95,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
source "init/Kconfig"
menu "Processor type and features"
Index: linux-2.6-lttng.stable/arch/x86/Kconfig.x86_64
===================================================================
--- linux-2.6-lttng.stable.orig/arch/x86/Kconfig.x86_64 2007-10-30 20:18:38.000000000 -0400
+++ linux-2.6-lttng.stable/arch/x86/Kconfig.x86_64 2007-10-30 20:19:08.000000000 -0400
@@ -137,6 +137,10 @@ config ARCH_SUPPORTS_OPROFILE
bool
default y
+config ARCH_SUPPORTS_KPROBES
+ bool
+ default y
+
source "init/Kconfig"
Index: linux-2.6-lttng.stable/kernel/Kconfig.instrumentation
===================================================================
--- linux-2.6-lttng.stable.orig/kernel/Kconfig.instrumentation 2007-10-30 20:19:10.000000000 -0400
+++ linux-2.6-lttng.stable/kernel/Kconfig.instrumentation 2007-10-30 20:19:20.000000000 -0400
@@ -32,7 +32,7 @@ config OPROFILE
config KPROBES
bool "Kprobes"
depends on KALLSYMS && MODULES
- depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32
+ depends on ARCH_SUPPORTS_KPROBES
help
Kprobes allows you to trap at almost any kernel address and
execute a callback function. register_kprobe() establishes
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
