Re: [PATCH 13/14] Blackfin SPI driver: Move cs_chg_udelay to cs_deactive to fix bug when some SPI LCD driver needs delay after cs_deactive

On Tuesday 30 October 2007, Bryan Wu wrote:
> @@ -211,6 +211,10 @@ static void cs_deactive(struct driver_data *drv_data, struct chip_data *chip)
>         flag |= (chip->flag << 8);
>  
>         write_FLAG(drv_data, flag);
> +
> +       /* Move delay here for consistency */
> +       if (chip->cs_chg_udelay)
> +               udelay(chip->cs_chg_udelay);
>  }
>  

By the way, if this is something needed very often, that mechanism
should be moved into the SPI framework.  It wouldn't be polite if
such LCD drivers could only work on Blackfin boards.  :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 13/14] Blackfin SPI driver: Move cs_chg_udelay to cs_deactive to fix bug when some SPI LCD driver needs delay after cs_deactive
    • From: Bryan Wu <[email protected]>

• References:
  • [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing
    • From: Bryan Wu <[email protected]>
  • [PATCH 13/14] Blackfin SPI driver: Move cs_chg_udelay to cs_deactive to fix bug when some SPI LCD driver needs delay after cs_deactive
    • From: Bryan Wu <[email protected]>

• Prev by Date: Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548
• Next by Date: Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing
• Previous by thread: [PATCH 13/14] Blackfin SPI driver: Move cs_chg_udelay to cs_deactive to fix bug when some SPI LCD driver needs delay after cs_deactive
• Next by thread: Re: [PATCH 13/14] Blackfin SPI driver: Move cs_chg_udelay to cs_deactive to fix bug when some SPI LCD driver needs delay after cs_deactive
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]