Re: [PATCH, RESEND] locks: fix possible infinite loop in posix deadlock detection

On Tue, 30 Oct 2007 11:20:02 -0400
"J. Bruce Fields" <[email protected]> wrote:

> From: J. Bruce Fields <[email protected]>
> 
> It's currently possible to send posix_locks_deadlock() into an infinite
> loop (under the BKL).
> 
> For now, fix this just by bailing out after a few iterations.  We may
> want to fix this in a way that better clarifies the semantics of
> deadlock detection.  But that will take more time, and this minimal fix
> is probably adequate for any realistic scenario, and is simple enough to
> be appropriate for applying to stable kernels now.
> 
> Thanks to George Davis for reporting the problem.
> 
> Cc: "George G. Davis" <[email protected]>
> Signed-off-by: J. Bruce Fields <[email protected]>

Acked-by: Alan Cox <[email protected]>

Its a good fix for now and I doubt any real world user has that complex a
locking pattern to break.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH] Fix hang in posix_locks_deadlock()
    • From: "George G. Davis" <[email protected]>
  • Re: [RFC][PATCH] Fix hang in posix_locks_deadlock()
    • From: "George G. Davis" <[email protected]>
  • Re: [RFC][PATCH] Fix hang in posix_locks_deadlock()
    • From: "J. Bruce Fields" <[email protected]>
  • Re: [RFC][PATCH] Fix hang in posix_locks_deadlock()
    • From: "J. Bruce Fields" <[email protected]>
  • [PATCH] locks: fix possible infinite loop in posix deadlock detection
    • From: "J. Bruce Fields" <[email protected]>
  • [PATCH, RESEND] locks: fix possible infinite loop in posix deadlock detection
    • From: "J. Bruce Fields" <[email protected]>

• Prev by Date: Re: dn_route.c momentarily exiting RCU read-side critical section
• Next by Date: Re: [RFC, PATCH] locks: remove posix deadlock detection
• Previous by thread: [PATCH, RESEND] locks: fix possible infinite loop in posix deadlock detection
• Next by thread: Re: [RFC][PATCH] Fix hang in posix_locks_deadlock()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]