Re: [PATCH 10/17] drivers/input/serio/i8042.c: irq handler clean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Torokhov wrote:
Hi Jeff,

On Sunday 21 October 2007, Jeff Garzik wrote:
commit bdf311215ef8dbae0254c092deaed1d5928b013e
Author: Jeff Garzik <[email protected]>
Date:   Fri Oct 19 19:28:54 2007 -0400

    drivers/input/serio/i8042.c: irq handler clean
* remove unnecessary prototype * distinguish between polled and irq-driven event handling * don't bother worrying about 'irq' function arg

I don't like these 2 changes. When I ask for debug data I really
want to know what interrupt (1 or 12) was raised in response to
a command. Your changes remove this visibility.

So noted...


    * dev_id passed to irq handlers is unused, to change the request_irq()
      argument to NULL

Does this really matter?

Does it has any effect on the computer?  No.

Does it has any effect on the human reviewer?  IMO yes :)

But it is a trivial matter.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux