Re: [PATCH] sysfs: add filter function to groups

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Mon, 29 Oct 2007 12:24:06 -0500,
James Bottomley <James.Bottomley@SteelEye.com> wrote:

> > Can you determine which subset of the attributes you want just before
> > actually creating the group? Then you could do something like:
> > 
> > create_group(grp, kobj)
> > {
> > 	grp->update_creation_mask(kobj);
> > 	actually_create_attrs();
> > }
> 
> That's actually what we currently do (at least in hand coded form) in
> the current transport classes.  However, it leads to one separate group
> for each attached class.  With the filter approach, we only need one
> constructed group for every transport class.

I meant doing it in the core. You still have one group for all cases,
but immediately before creating the attributes, the core checks back
which ones it should create. (Of course, that doesn't solve your
problems if you dynamically want to change availability of attributes
later on. You would need a different mechanism for that.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/