Re: [PATCH] Clean up scatterlist.h and introduce macros for readability.

On Mon, Oct 29 2007, Robert P. J. Day wrote:
> 
> Add some macros to <linux/scatterlist.h> to make the bit manipulation
> more readable, and expand on some of the documentation.
> 
> This patch incorporates content from Cyrill Gorcunov
> <[email protected]> as well.

I don't like it, I already explained why I don't consider the 'magic'
values a problem. The use of the bits is supposed to be scatterlist.h
private and the values are documented at the top of that include file.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Clean up scatterlist.h and introduce macros for readability.
    • From: "Cyrill Gorcunov" <[email protected]>

• References:
  • [PATCH] Clean up scatterlist.h and introduce macros for readability.
    • From: "Robert P. J. Day" <[email protected]>

• Prev by Date: RE: epoll design problems with common fork/exec patterns
• Next by Date: [PATCH, RFC] hacks to allow -rt to run kernbench on POWER
• Previous by thread: Re: [PATCH] Clean up scatterlist.h and introduce macros for readability.
• Next by thread: Re: [PATCH] Clean up scatterlist.h and introduce macros for readability.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]