Re: [PATCH] backlight dimmer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 28 Oct 2007 22:30:55 +0100
"[email protected]" <[email protected]> wrote:

> Ok,
>   now checkpatch.pl only complains about a missing signed-off-by.
> Is this ok for review?


hi,

when going over your patch.. is there a reason you introduce yet
another timeout infrastructure? Is there something wrong with the
existing ones that maybe should be fixed instead?
Either way.. please put justification for such new mechanism in the
patch changelog....

Greetings,
   Arjan van de Ven

-- 
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux