Re: [PATCH] usbserial: fix inconsistent lock state

On Sun, 28 Oct 2007, Borislav Petkov wrote:

> ---
> In commit acd2a847e7fee7df11817f67dba75a2802793e5d usb_serial_generic_write()
> disables interrupts when taking &port->lock which is also taken in
> usb_serial_generic_read_bulk_callback() resulting in an inconsistent lock state
> due to the latter not disabling interrupts on the local cpu. Fix that by
> disabling interrupts in the latter call site also.
> Signed-off-by: Borislav Petkov <[email protected]>

You are right, I missed the usb_serial_generic_read_bulk_callback() one, 
thanks for catching this.

	Acked-by: Jiri Kosina <[email protected]>

-- 
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] usbserial: fix inconsistent lock state
    • From: Borislav Petkov <[email protected]>

• Prev by Date: Re: eradicating out of tree modules
• Next by Date: Re: eradicating out of tree modules
• Previous by thread: [PATCH] usbserial: fix inconsistent lock state
• Next by thread: [PATCH] coding style cleanups for drivers/md/mktables.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]