Re: [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S

Mathieu Desnoyers <[email protected]> writes:

> We make sure that the thread flag read is coherent between our new test and the ALLWORK_MASK test by first saving it in a register used for both comparisons.
>

That doesn't make sense. If someone is setting those asynchronously you 
can always race.

You should really just stop the process like ptrace does before changing
such things.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S
  - From: Mathieu Desnoyers <[email protected]>

References:
- Adding TIF_TRACE_KERNEL to x86_64
  - From: Mathieu Desnoyers <[email protected]>
- [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S
  - From: Mathieu Desnoyers <[email protected]>

Prev by Date: Re: 2.6.24-rc1: First impressions
Next by Date: Re: [linux-usb-devel] USB HCD: avoid duplicate local_irq_disable()
Previous by thread: [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S
Next by thread: Re: [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]