Re: [PATCH 7/9] irq-remove: scsi driver trivial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 19 Oct 2007 09:00:23 -0400
"Salyzyn, Mark" <[email protected]> wrote:

> ACK with comment ...

Please don't top-post and then include 65 kbytes of unneeded goop.

> This API changed in 2.4.23 switching to irqreturn_t, and 2.6.19 dropping
> the struct_pt_regs argument, this is yet another API change in the same
> function. The last one came with no clues to differentiate except kernel
> version (for those of us that are required to produce updated
> back-ported driver modules once this patch becomes a legacy). I am
> *praying* that this API change is clean across 2.6.24 and add my voice
> to all to ACK this clearly!
> 

That was a goofup.  I proposed that we should add a #define
TWO_ARG_IRQ_HANDLERS (or whatever) and I think I actually wrote the patch,
but it got lost.

I agree it would be a kind thing to do in this case.

Not that I ever want to see these patches again ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux