Re: [PATCH] [POWERPC] Fix CONFIG_SMP=n build break

On Friday 26 October 2007, Olof Johansson wrote:
> Fix two build errors on powerpc allyesconfig + CONFIG_SMP=n:
>
> arch/powerpc/platforms/built-in.o: In function `cpu_affinity_set':
> arch/powerpc/platforms/cell/spu_priv1_mmio.c:78: undefined reference to
> `.iic_get_target_id' arch/powerpc/platforms/built-in.o: In function
> `iic_init_IRQ':
> arch/powerpc/platforms/cell/interrupt.c:397: undefined reference to
> `.iic_setup_cpu'

Thanks for reporting this.

> --- a/arch/powerpc/platforms/cell/spu_priv1_mmio.c
> +++ b/arch/powerpc/platforms/cell/spu_priv1_mmio.c
> @@ -75,9 +75,11 @@ static u64 int_stat_get(struct spu *spu, int class)
>  
>  static void cpu_affinity_set(struct spu *spu, int cpu)
>  {
> +#ifdef CONFIG_SMP
>         u64 target = iic_get_target_id(cpu);
>         u64 route = target << 48 | target << 32 | target << 16;
>         out_be64(&spu->priv1->int_route_RW, route);
> +#endif
>  }

I think here it would be better to move iic_get_target_id out of
CONFIG_SMP as well. We might want to kexec from an SMP kernel into
a UP kernel, and in that case, cpu_affinity_set() should better
reset the routing to CPU 0.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH v2] [POWERPC] Fix CONFIG_SMP=n build break
    • From: Olof Johansson <[email protected]>

• References:
  • [PATCH] [POWERPC] Fix CONFIG_SMP=n build breaks
    • From: Olof Johansson <[email protected]>

• Prev by Date: Re: [RFC] full suspend/resume support for i915 DRM driver
• Next by Date: [PATCH] iommu-PMEN_REG boot up support
• Previous by thread: [PATCH] [POWERPC] Fix CONFIG_SMP=n build breaks
• Next by thread: [PATCH v2] [POWERPC] Fix CONFIG_SMP=n build break
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]