Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Linus Torvalds wrote:

We can just convert cariables declared as 'struct hpt_info' to const too -- they are read-only templates.

Generally "__devinitdata" is better than "const", since it means that the data may be thrown away.

   Agreed.

So if you drop one over the other,

   No, just add 'const' to already __devinitdata data to make gcc happy again.

it's generally the "const" that should be dropped ;/

Well, this may break when/if we need to add __devinitdata that is actually r/w -- not likely with this driver but still...

		Linus

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux