Re: [PATCH] [RFC] brk randomization: compute RLIMIT_DATA properly (was Re: x86: randomize brk() and RLIMIT_DATA)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Oct 2007, Jan Engelhardt wrote:
> On Oct 26 2007 13:30, Hugh Dickins wrote:
> >> @@ -251,7 +251,8 @@ asmlinkage unsigned long sys_brk(unsigned long brk)
> >>  	 * not page aligned -Ram Gupta
> >>  	 */
> >>  	rlim = current->signal->rlim[RLIMIT_DATA].rlim_cur;
> >> -	if (rlim < RLIM_INFINITY && brk - mm->start_data > rlim)
> >> +	if (rlim < RLIM_INFINITY && (brk - mm->start_brk) +
> >> +			(mm->end_data - mm->start_data) > rlim)
> >>  		goto out;
> >>  
> >>  	newbrk = PAGE_ALIGN(brk);
> 
> Parentheses around (brk - mm->start_brk) + (mm->end_data - mm->start_data)
> not strictly necessary.

Yes, but don't you find they make it easier to understand the expression?

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux