Re: [PATCH 1/4] stringbuf: A string buffer implementation

Hi,

On 10/24/07, Matthew Wilcox <[email protected]> wrote:
> +static void sb_vprintf(struct stringbuf *sb, const char *format, va_list args)
> +{
> +       char *s;
> +       int size;
> +
> +       if (sb->alloc == -ENOMEM)
> +               return;
> +       if (sb->alloc == 0) {
> +               sb->s = kmalloc(INITIAL_SIZE, GFP_ATOMIC);

How about putting ->gfp_flags to struct stringbuf and initializing
that in sb_init() instead of hard-coding to GFP_ATOMIC here?

Btw, the "sb" abbrevation is already used for "superblock". Perhaps we
could use "str" for these?

                                             Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/4] stringbuf: A string buffer implementation
    • From: Matthew Wilcox <[email protected]>

• Prev by Date: Re: [PATCH] [RFC] brk randomization: compute RLIMIT_DATA properly (was Re: x86: randomize brk() and RLIMIT_DATA)
• Next by Date: finding unused Kconfig variables in the source tree
• Previous by thread: Re: [PATCH 1/4] stringbuf: A string buffer implementation
• Next by thread: Re: [PATCH 1/4] stringbuf: A string buffer implementation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]