Re: [PATCH] Better document profile=

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 25 Oct 2007 22:03:21 -0700 "Russ Dill" <russ.dill@gmail.com> wrote:

> > >                       Format: [schedule,]<number>
> > >                       Param: "schedule" - profile schedule points.
> > >                       Param: <number> - step/bucket size as a power of 2 for
> > > -                             statistical time based profiling.
> > > +                             statistical time based profiling. A value of
> > > +                             2 will provide a granularity of 4 bytes, a
> > > +                             value of 3 will provide a granularity of 8
> > > +                             bytes and so on.
> > >                       Param: "sleep" - profile D-state sleeping (millisecs)
> >
> > Actually the prof_shift isn't in units of bytes: it is in units of
> > sizeof(unsigned long).
> 
> 
> I thought we just went through this?

Just.  I seem to recall discussing this with someone a number of weeks ago.
Sorry, but my memory gets flushed a lot more frequently than that.

> extern char _text[], _stext[], _etext[];
> [...]
> prof_len = (_etext - _stext) >> prof_shift;
> prof_buffer = alloc_bootmem(prof_len*sizeof(atomic_t));
> 

ok, you're right.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/