Re: [PATCH] ISDN/capidrv: fix casting warning

[Jeff Garzik <jeff@garzik.org>]

Karsten Keil wrote:
> On Thu, Oct 25, 2007 at 04:06:16AM -0400, Jeff Garzik wrote:
> > drivers/isdn/capi/capidrv.c: In function 'if_sendbuf':
> > drivers/isdn/capi/capidrv.c:1865: warning: cast from pointer to integer
> > of different size
> >
> > We are passing a kernel pointer, skb->data, but the interface itself is
> > limited to 32 bits.  A future changeset may want to mark this code
> > 32-bit only, if it turns out cmsg->Data value truncation on 64-bit
> > platforms is problematic in practice.
>
> I think I should really add somewhere a comment for this issue.
> This field is not used in practice in linux kernel (neither in 32 or
> 64 bit), but should have some value, since a CAPI message trace will
> display it.
> The correct value in the 32 bit case is the address of the
> data, in 64 bit it makes no sense, maybe we should use 0 here.

So noted...  I will make sure the next revision of the patch fulfills 
all your wishes :)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/