Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]

 > > +static inline void *ERR_CAST(const void *ptr)
 > > +{
 > > +	return (void *) ptr;
 > > +}
 > 
 > Just to nit, surely you don't need the cast inside the function.  The
 > casting happens at the call site between the argument and returned pointer.

The way it's written you kinda do, since it takes a const void * and
returns a plain void *.  But I don't think that's the best way to
write it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]
    • From: Zach Brown <[email protected]>

• References:
  • [PATCH 00/31] Remove iget() and read_inode() [try #5]
    • From: David Howells <[email protected]>
  • [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]
    • From: David Howells <[email protected]>
  • Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]
    • From: Zach Brown <[email protected]>

• Prev by Date: Re: [PATCH] Better document profile=
• Next by Date: Re: IRQ off latency of printk is very high
• Previous by thread: Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]
• Next by thread: Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]