Re: [PATCH 3/6] x86: unification of i386 and x86_64 Kconfig.debug

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On 10/25/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> From 16b853f53463e43bfce341965ac10a78a3755a14 Mon Sep 17 00:00:00 2001
> From: Randy Dunlap <rdunlap@xenotime.net>
> Date: Wed, 24 Oct 2007 15:50:43 -0700
> Subject: [PATCH] x86: unification of i386 and x86_64 Kconfig.debug
>
> Adding proper dependencies so the two Kconfig.debug files
> are now identical.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  arch/i386/Kconfig.debug             |   51 ++++++++++++++++++++++++++++-------
>  arch/x86_64/Kconfig                 |    4 ---
>  arch/{i386 => x86_64}/Kconfig.debug |   51 ++++++++++++++++++++++++++++-------
>  3 files changed, 82 insertions(+), 24 deletions(-)
>  copy arch/{i386 => x86_64}/Kconfig.debug (65%)
>
> diff --git a/arch/i386/Kconfig.debug b/arch/i386/Kconfig.debug
> index f03531e..970b2de 100644
> --- a/arch/i386/Kconfig.debug
> +++ b/arch/i386/Kconfig.debug
> @@ -1,14 +1,14 @@
>  menu "Kernel hacking"
>
>  config TRACE_IRQFLAGS_SUPPORT
> -       bool
> -       default y
> +       def_bool y
>
>  source "lib/Kconfig.debug"
>
>  config EARLY_PRINTK
>         bool "Early printk" if EMBEDDED && DEBUG_KERNEL
>         default y
> +       depends on X86_32
>         help
>           Write kernel log output directly into the VGA buffer or to a serial
>           port.
> @@ -37,10 +37,12 @@ config DEBUG_STACK_USAGE
...
> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
> index 308970a..1bc0268 100644
> --- a/arch/x86_64/Kconfig
> +++ b/arch/x86_64/Kconfig
> @@ -97,10 +97,6 @@ config X86_CMPXCHG
>         bool
>         default y
>
> -config EARLY_PRINTK
> -       bool
> -       default y
> -
>  config GENERIC_ISA_DMA
>         bool
>         default y
> diff --git a/arch/i386/Kconfig.debug b/arch/x86_64/Kconfig.debug
> similarity index 65%
> copy from arch/i386/Kconfig.debug
> copy to arch/x86_64/Kconfig.debug
> index f03531e..970b2de 100644
> --- a/arch/i386/Kconfig.debug
> +++ b/arch/x86_64/Kconfig.debug
> @@ -1,14 +1,14 @@
>  menu "Kernel hacking"
>
>  config TRACE_IRQFLAGS_SUPPORT
> -       bool
> -       default y
> +       def_bool y
>
>  source "lib/Kconfig.debug"
>
>  config EARLY_PRINTK
>         bool "Early printk" if EMBEDDED && DEBUG_KERNEL
>         default y
> +       depends on X86_32
>         help
>           Write kernel log output directly into the VGA buffer or to a serial
>           port.
...

why disabling early_printk for x86_64?

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/