Re: [PATCH 3/3] drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings

On Thursday 25 October 2007, Jeff Garzik wrote:
> * We shouldn't bother with dev->current_state, the PCI API functions we
>   call manage this for us (and do a far better job at it too).
> 
> * Remove pci_set_power_state(dev, PCI_D0) call in resume, as
>   pci_enable_device() does the same thing.
> 
> * Check pci_enable_device() return value.  If it failed, fail
>   the entire resume and avoid programming timings into the [potentially
>   dead/asleep] chip.
> 
> Signed-off-by: Jeff Garzik <[email protected]>

applied, thanks
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] sound/oss/pss: set_io_base() always returns success, mark it void
    • From: Jeff Garzik <[email protected]>
  • [PATCH 3/3] drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [PATCH 2/3] drivers/ide/pci/sc1200.c: remove pointless hwif lookup loop
• Next by Date: Re: [2.6 patch] blackfin: "extern inline" -> "static inline"
• Previous by thread: [PATCH 3/3] drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings
• Next by thread: [PATCH 2/4] [SCSI] ips: trim trailing whitespace
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]