Re: [lm-sensors] hwmon/f75375s.c: buggy if()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Riku,

On Wed, 24 Oct 2007 14:50:34 +0300, Riku Voipio wrote:
> On Fri, Oct 19, 2007 at 02:37:54PM +0200, Jean Delvare wrote:
> > Take a look at the w83781d
> > driver for an example.
> 
> Btw, I think your example code has a indentation bug:
> 
> 		if (kind != w83781d)
> 			err = sysfs_chmod_file(&dev->kobj,
> 				&sensor_dev_attr_temp3_alarm.dev_attr.attr,
> 				S_IRUGO | S_IWUSR);
> 			if (err)
> 				return err;

Indentation is correct, but curly braces are missing! Nice catch,
thanks for reporting. It happens to be harmless in this specific case,
but it still needs fixing. I'll submit a patch shortly.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux