Re: [patch 1/5] wait: use lock bitops for __wait_on_bit_lock

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 24 Oct 2007 18:13:06 +1000 npiggin@nick.local0.net wrote:

> Signed-off-by: Nick Piggin <npiggin@suse.de>
> 
> ---
>  kernel/wait.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/kernel/wait.c
> ===================================================================
> --- linux-2.6.orig/kernel/wait.c
> +++ linux-2.6/kernel/wait.c
> @@ -195,7 +195,7 @@ __wait_on_bit_lock(wait_queue_head_t *wq
>  			if ((ret = (*action)(q->key.flags)))
>  				break;
>  		}
> -	} while (test_and_set_bit(q->key.bit_nr, q->key.flags));
> +	} while (test_and_set_bit_lock(q->key.bit_nr, q->key.flags));
>  	finish_wait(wq, &q->wait);
>  	return ret;
>  }
> 

Sorry, I'm just not going to apply a patch like that.

I mean, how the heck is anyone else supposed to understand what you're up
to?  There's a bit of documentation in Documentation/atomic_ops.txt
(probably enough, I guess) but it is totally unobvious to 98.3% of kernel
developers when they should use test_and_set_bit() versus
test_and_set_bit_lock() and it is far too much work to work out why it was
used in __wait_on_bit_lock(), whether it is correct, what advantages it
brings and whether and where others should emulate it.

So in my opinion this submission isn't of sufficient quality to be
included in Linux.

IOW: please write changelogs.  Preferably good ones.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/