Re: [patch] portman2x4.c: fix boot hang

Ingo Molnar wrote:
>  if ((parport_read_status(p) & ESTB) == ESTB)
> -		return 1;	/* CODE 1 - Strobe Failure. */
> +		return -EIO;	/* CODE 1 - Strobe Failure. */
>  
>  /* Set for RXDATA0 where no damage will be done. */
>  /* 5 */
> @@ -475,7 +475,7 @@ static int portman_probe(struct parport
>  
>  /* 6 */
>  if ((parport_read_status(p) & ESTB) != ESTB)
> -		return 1;	/* CODE 1 - Strobe Failure. */
> +		return -EIO;	/* CODE 1 - Strobe Failure. */

Why are you keeping the "CODE 1" comment? Just "Strobe Failure" as comment 
would seem more consistent with the change.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] portman2x4.c: fix boot hang
    • From: Ingo Molnar <[email protected]>

• References:
  • Linux v2.6.24-rc1
    • From: Linus Torvalds <[email protected]>
  • [patch] portman2x4.c: fix boot hang
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [2.6 patch] unexport icmpmsg_statistics
• Next by Date: Re: [RFC] full suspend/resume support for i915 DRM driver
• Previous by thread: [patch] portman2x4.c: fix boot hang
• Next by thread: Re: [patch] portman2x4.c: fix boot hang
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]