Hi!
> We seem to see a lot of bug reports along the lines of, "my machine
> resumes but I can't see X" or, "I can see X but only with a bright
> flashlight", etc. These sorts of problems are due to the fact that
> the X server isn't designed to do full state save/restore, and none
> of the available kernel drivers do it on its behalf.
>
> Since intelfb and the rest of the Intel drivers are fairly incompatible,
> this patch makes the DRM bind to the PCI device so it can register real
> suspend/resume handlers. Those handlers take care of saving and
> restoring enough state for X to come back reliably on at least one of my
> problematic test machines, but text mode still has trouble (still
> debugging VGA state save/restore, including trying to save/restore
> actual VRAM contents for possible hibernate support).
>
> How does this approach look? Is a new DRM driver flag a good thing for
> similar situations with other drivers? Thoughts?
Looks okay to me... from very quick look.
> + if (!i915_pipe_enabled(dev, pipe))
> + return;
> +
> + if (pipe == PIPE_A)
> + array = dev_priv->savePaletteA;
coding style, we probably want save_palette_A.
> + unsigned long reg = pipe == PIPE_A ? PALETTE_A : PALETTE_B;
Uff. Mixing = and == and ? in one expression is evil.
I think I seen some #if 0 code.... just remove that.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
