Re: [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration

Hi Gregory,

On Tuesday 23 October 2007, Gregory Haskins wrote:
> Calculating the weight is probably relatively expensive, so it is only
> done when the cpus_allowed mask is updated (which should be relatively
> infrequent, especially compared to scheduling frequency) and cached in
> the task_struct.

Why not make it a task flag, since according to your code, you are only 
interested whether this is <= 1 or > 1. Since !(x <= 1) <=> (x > 1)
for any given unsigned integer x, the required data structure is
a "boolean" or a flag.


Best Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration
    • From: Gregory Haskins <[email protected]>

• References:
  • [PATCH 00/13] Balance RT tasks v5
    • From: Gregory Haskins <[email protected]>
  • [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration
    • From: Gregory Haskins <[email protected]>

• Prev by Date: [PATCH] Fix unlocking before return in gpio
• Next by Date: Re: [PATCH] defxx.c: dfx_bus_init() is __devexit not __devinit
• Previous by thread: [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration
• Next by thread: Re: [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]