Re: [PATCH -v7 1/3] x86 boot: setup data

Jeremy Fitzhardinge wrote:

 1:
+	movl boot_params - __PAGE_OFFSET + SETUP_DATA_POINTER,%ebp

You need to check the boot protocol version before looking at this pointer.

No, he doesn't. The boot protocol version is communication between the boot loader and the kernel (specifically, it is communication FROM the kernel TO the bootloader), not between internal bits of the kernel. Th

Since the pointer is safely inside the setup template, even if the bootloader doesn't understand boot protocol version 2.08 it will have copied it.

So this is fine.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH -v7 1/3] x86 boot: setup data
    • From: Jeremy Fitzhardinge <[email protected]>

• References:
  • [PATCH -v7 1/3] x86 boot: setup data
    • From: "Huang, Ying" <[email protected]>
  • Re: [PATCH -v7 1/3] x86 boot: setup data
    • From: Jeremy Fitzhardinge <[email protected]>

• Prev by Date: Re: [PATCH] [RESEND] i386 and x86_64: randomize brk()
• Next by Date: Re: [RFD] iptables: mangle table obsoletes filter table
• Previous by thread: Re: [PATCH -v7 1/3] x86 boot: setup data
• Next by thread: Re: [PATCH -v7 1/3] x86 boot: setup data
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]