Re: [PATCH] LinuxPPS - PPS support for Linux

[Dave Jones <davej@redhat.com>]

On Tue, Oct 23, 2007 at 08:04:18PM +0200, Rodolfo Giometti wrote:

Hi Rodolfo,
 
 > here my last patch for PPS support.
 > 
 > Please, let me know if I have something to do for kernel inclusion.

Thanks for trying to get this merged, we've had a few users asking
us to support this in the Fedora kernel.

>From a quick look through, it doesn't look too bad.
A couple of obvious things that jumped out..

* The example program in the Documentation dir.
  There was some discussion recently about moving away 
  from doing this, and instead moving code to the samples/ dir
  (or including it in util-linux instead if applicable).

 > +    static struct pps_source_info_s pps_ktimer_info = {
 > +            name         : "ktimer",
 > +            path         : "",
 > +            mode         : PPS_CAPTUREASSERT | PPS_OFFSETASSERT | \
 > +			   PPS_ECHOASSERT | \
 > +                           PPS_CANWAIT | PPS_TSFMT_TSPEC,
 > +            echo         : pps_ktimer_echo,
 > +            owner        : THIS_MODULE,
 > +    };

  should be
    .name = "ktimer"
  etc..

 > +#include <linux/version.h>

This should be getting included automatically for you.

On the whole, asides from these (very) minor nits, quite a clean
submission compared to a lot of new driver submissions to lkml.
Might want to run it through scripts/checkpatch.pl too to see
if that picks up any more minor fluff.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/