Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud_rate

["Maciej W. Rozycki" <macro@linux-mips.org>]

On Wed, 17 Oct 2007, Alan Cox wrote:

> >  The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has 
> > a problem with the baud_table within.  The comparison operators are 
> > reversed and as a result this table's entries never match and BOTHER is 
> > always used.
> 
> Oops. I thought I'd fixed that one. Bit bothersome its been in -mm that
> long before anyone noticed. 

 -ENOTENOUGHUSERS?

> >  Additionally this function's prototype is not exported unlike the 
> > function itself.
> 
> That bit seems out of date and a prototype was added later in -mm

 Given the function has survived for quite a while without a prototype 
exported (how to use it otherwise? -- I guess set_sgttyb() does not count 
as hardly anybody should be calling it), I suppose it is no surprise it 
was not adequately tested. ;-)

  Maciej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/