cyclades, fix potential NULL dereference
to ztxdone is jumped even if tty is NULL and tty_wakeup placed after this
label doesn't expect NULLed parameter, so this will cause an oops in some
situations (why they scheduled a wakeup there before remove bottom half
processing patch?). wakeup only in the case when we have non-null tty
struct.
Spotted by Adrian Bunk.
Signed-off-by: Jiri Slaby <[email protected]>
Cc: Adrian Bunk <[email protected]>
---
commit d5e700a2247a9dc66cda09e6d89d1dc284bda40b
tree e0ba44e65a2026e4cba1e158580eaf492a1bfa35
parent bd9d07361314f393c7686466687c0a7aa8e88109
author Jiri Slaby <[email protected]> Mon, 22 Oct 2007 20:47:01 +0200
committer Jiri Slaby <[email protected]> Mon, 22 Oct 2007 20:47:01 +0200
drivers/char/cyclades.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
index d15234c..710c056 100644
--- a/drivers/char/cyclades.c
+++ b/drivers/char/cyclades.c
@@ -1604,8 +1604,8 @@ static void cyz_handle_tx(struct cyclades_port *info,
info->icount.tx++;
}
#endif
-ztxdone:
tty_wakeup(tty);
+ztxdone:
/* Update tx_put */
cy_writel(&buf_ctrl->tx_put, tx_put);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
