Re: [PATCH] unlock before bug returns

Roel Kluin wrote:

>     unlock before bug returns

>  	if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) {
>  		printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
> -		BUG();
>  		spin_unlock(&gpmc_mem_lock);
> -		return;
> +		BUG();


should we bother to unlock before panicking, or is the unlock not required either?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] unlock before bug returns
  - From: Rik van Riel <[email protected]>

References:
- [PATCH] unlock before bug returns
  - From: Roel Kluin <[email protected]>

Prev by Date: [2.6 patch] kill UDFFS_{DATE,VERSION}
Next by Date: Re: [PATCH] return hidden bug
Previous by thread: [PATCH] unlock before bug returns
Next by thread: Re: [PATCH] unlock before bug returns
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]