Avi Kivity a écrit :
Laurent Vivier wrote:
Avi Kivity a écrit :
Avi Kivity wrote:
The following patches fix fallout from the main 2.6.24 KVM merge. An
exception is the movnti emulation patch, which adds support for Linux
2.6.16 guests.
The patches can be found in kvm.git in the branch kvm-updates-2.6.24.
There is also a branch kvm-updates-2.6.25 which will form the basis of
the next merge window submission.
Please review the patches and let me know if something is wrong or if
a patch is missing.
Laurent, I believe the following patch (in kvm-updates-2.6.25) needs
to go into 2.6.24 as well. Can you comment on this?
What kind of comment do you want ?
Well, whether it needs to go into .24.
What are the requirements to go in 2.6.24 instead of 2.6.25 ?
Is a bug correction enough ? :-P
It has to fix something real-life, in a real guest.
This patch correct a bad behavior of x86_emulate_insn() in case of
error with a REP prefix.
This patch is needed because, without it, when REP prefix is used with
an instruction failing for some reasons (like IO or page fault) we
don't restore all modified registers (like RSI and RDI), but only ECX
and EIP, so when we re-enter in x86_emulate_insn() we modify again an
already modified value. Moreover, this patch manages correctly the
case where the instruction fails in writeback().
Okay, I guess it is needed. Can you backport it to the branch? It's
very different from kvm-updates-2.6.24...
Well, in fact it is not needed in 2.6.24, because this patch correct a bad
behavior introduced by commit 57f4e446ebca4aad5c11364baf8477c8cfcb16a4 (which is
not in kvm-update-2.6.24):
KVM: Call x86_decode_insn() only when needed
Move emulate_ctxt to kvm_vcpu to keep emulate context when we exit from kvm
module. Call x86_decode_insn() only when needed. Modify x86_emulate_insn() to
not modify the context if it must be re-entered.
So, in fact, the answer is (after correctly understanding the question): no,
this patch is not needed in kvm-update-2.6.24.
Regards,
Laurent
--
---------------- [email protected] -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
