[PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work

(untested, needs an explicit ack/nack from maintainer)

blk_sync_queue() cancels the timer, but forgets to cancel the work.

Signed-off-by: Oleg Nesterov <[email protected]>

--- K/block/ll_rw_blk.c~2_blk	2007-10-13 14:51:42.000000000 +0400
+++ K/block/ll_rw_blk.c	2007-10-20 16:10:08.000000000 +0400
@@ -1723,6 +1723,7 @@ EXPORT_SYMBOL(blk_stop_queue);
 void blk_sync_queue(struct request_queue *q)
 {
 	del_timer_sync(&q->unplug_timer);
+	kblockd_flush_work(&q->unplug_work);
 }
 EXPORT_SYMBOL(blk_sync_queue);
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work
    • From: Jens Axboe <[email protected]>

• Prev by Date: [PATCH 1/2] cfq_exit_queue() should cancel cfq_data->unplug_work
• Next by Date: Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]
• Previous by thread: [PATCH 1/2] cfq_exit_queue() should cancel cfq_data->unplug_work
• Next by thread: Re: [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]