Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions

On Fri, 19 Oct 2007 13:18:23 -0600
[email protected] wrote:

> +static inline unsigned long deap_pfn(u8 edeap, u32 deap)
> +{
> +	deap >>= PAGE_SHIFT;
> +	deap |= (edeap & 1) << (32 - PAGE_SHIFT);
> +	return deap;
> +}
> +
> +static inline unsigned long deap_offset(u32 deap)
> +{
> +	return deap & ~(I3000_DEAP_GRAIN - 1) & ~PAGE_MASK;
> +}
> +

The types here look a bit confused.  Implicit conversions of
u32s into unsigned longs.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions
    • From: Jason Uhlenkott <[email protected]>
  • Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions
    • From: Doug Thompson <[email protected]>

• References:
  • [PATCH 6/8] drivers-edac-i3000 replace macros with functions
    • From: [email protected]

• Prev by Date: Re: [PATCH 4/8] drivers-edac-add Cell MC driver
• Next by Date: Re: New CD/DVD drive - 80-wire cable detection failure
• Previous by thread: [PATCH 6/8] drivers-edac-i3000 replace macros with functions
• Next by thread: Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]