Re: [PATCH 1/9] irq-remove: core

[Jeff Garzik <jeff@garzik.org>]

Eric W. Biederman wrote:
> Jeff Garzik <jeff@garzik.org> writes:
>
> > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> > index 80eab7a..92e1456 100644
> > --- a/kernel/irq/manage.c
> > +++ b/kernel/irq/manage.c
> > @@ -455,7 +455,7 @@ void free_irq(unsigned int irq, void *dev_id)
> >  			 */
> >  			if (action->flags & IRQF_SHARED) {
> >  				local_irq_save(flags);
> > -				action->handler(irq, dev_id);
> > +				action->handler(dev_id);
> >  				local_irq_restore(flags);
> >  			}
> >  #endif
> > @@ -549,7 +549,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
> >  		unsigned long flags;
> >  
> >  		local_irq_save(flags);
> > -		handler(irq, dev_id);
> > +		handler(dev_id);
> >  		local_irq_restore(flags);
> >  	}
> >  #endif
>
> The above two hunks need to call set_irqfunc_irq in your model.

Duh.  Thanks for pointing out an obvious mistake :)

Fixed and checked into 'irq-remove' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/