Re: [PATCH 2/9] irq-remove: arch non-trivial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric W. Biederman wrote:
In this case we can easily pass the irqno into request_irq, allowing
us to do "unsigned int intno = (unsigned int)dev_id;".

I suspect this is the case for the majority of the non-trivial users
as well.


Not that easy, alas :) Save for weirdos like the mac drivers I highlighted, it seems like most drivers in the non-trivial already pass a useful pointer to request_irq().

But as I mentioned, most of the "non-trivial" uses are actually trivial -- just not as simple as removing the 'int irq' argument. Most of the time the irq number is used in non-critical ways like printk's. A few times its used to index into a structure (something dev_id could replace).

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux